Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract post body and get parameters parsing #102

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Abstract post body and get parameters parsing #102

merged 6 commits into from
Oct 30, 2024
+390 −262

Conversation

ioigoume
Copy link
Contributor

@ioigoume ioigoume commented Oct 24, 2024 •
edited
Loading

@ioigoume ioigoume marked this pull request as draft October 24, 2024 09:30
@ioigoume ioigoume marked this pull request as ready for review October 25, 2024 16:04
pradtke
pradtke requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@pradtke pradtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests and I think we also will need some adjustments in OAuth2Controller->linkback() to handle the response being a POST. Currently the code assumes the code is a query parameter.

@ioigoume ioigoume requested a review from pradtke October 27, 2024 09:46
@ioigoume
Copy link
Contributor Author

I did some tests and I think we also will need some adjustments in OAuth2Controller->linkback() to handle the response being a POST. Currently the code assumes the code is a query parameter.

Hi @pradtke , i refactored the code according to your comments.

@pradtke pradtke merged commit dfd52e1 into cirrusidentity:master Oct 30, 2024
5 checks passed
@pradtke
Copy link
Contributor

pradtke commented Oct 30, 2024

Thank you @ioigoume . Apple logins are working for me again.

@ioigoume ioigoume deleted the SSP-2035_authoauth2_module_switch_to_routes_and_controllers_fix_parsing_data branch October 31, 2024 08:24
@pradtke pradtke mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradtke pradtke pradtke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioigoume @pradtke